Fix release body generation #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
approved these changes
Feb 27, 2023
Collaborator
Shillaker
left a comment
There was a problem hiding this comment.
Feels like there should be a library out there that does this off-the-shelf, but this works 👍
975ad0e to
f5b4803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the release generating script using a third-party docker image was not working. My guess is that it was trying to index all the files in all the submodules, what was taking a very very long time.
Given that our requirements for release bodies are rather low, I implement a python function to generate the exact same release body.
Once the
wasi-libc-related PRs are merged in, I will publish a new release.