Task to bump tracked submodule version and check submodule tracked branch #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Feb 13, 2023
| new_ver = ver | ||
| bump_faasm_ver = (not python) and (not cpp) | ||
| if bump_faasm_ver: | ||
| old_ver = get_version() |
Collaborator
Author
There was a problem hiding this comment.
Faasm's bumping logic is the same, just indented.
csegarragonz
commented
Feb 13, 2023
| runs-on: ubuntu-latest | ||
| container: | ||
| image: faasm/cpp-sysroot:0.2.0 | ||
| image: faasm/cpp-sysroot:0.2.1 |
Collaborator
Author
There was a problem hiding this comment.
The motivation for this PR is that I realised that these versions were out of sync, and I have been forgetting often lately 🤦
9515b1c to
d8820f0
Compare
d8820f0 to
f25fb80
Compare
56cd596 to
4ca6399
Compare
4ca6399 to
cd66e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that the value of
./clients/[python,cpp]/VERSIONis the same than the one we use (i) in the gha file, and (ii) indocker compose(and transitively in thequick-starttests).This PR adds:
I include the new check in the old
formattingjob, that I now re-factor tochecks.Whilst I am at it, I also include a check that makes sure that all submodules point to the
mainbranch. On the down side, this means that a PR spanning multiple repos (as it happens often) will never be fully green until all submodules have been merged in. On the up side, this will prevent the very frequent issue of forgetting to update the branch after merge, which is quite non-intuitive.