Latest wasi-libc
#719
Merged
Latest wasi-libc
#719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18f28f0 to
b07e4a0
Compare
csegarragonz
commented
Feb 21, 2023
|
|
||
| WasmModule::~WasmModule() {} | ||
|
|
||
| void WasmModule::flush() {} |
Collaborator
Author
There was a problem hiding this comment.
This diff is very convoluted and hard to read. See here for the file and search for FAASM_HAS_WASM_MMAN.
The reason is that I wanted to conditionally compile the memory-management-related functions (similarly to what I do in include/wasm/WasmModule.h). However, I realised that the function definitions where not groupped in the same way that we declare them in the header file, so I re-arrange them to be so.
If preferred, I can just surgically conditionally compile the functions across this file and undo the re-ordering.
I am also aware that defining functions in the order we declare them is not something we enforce, but I still think is a nice-to-have.
346c274 to
e46740b
Compare
Shillaker
approved these changes
Feb 27, 2023
…t support PROT_EXEC
ad2ae27 to
6d6cbca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I bump the
cppandpythondependencie's to make our sysroot use the latest version ofwasi-libc.The changes here are just small fixes of problems that arised as a consequence of the merge. Most importantly, WASM's new command/reactor model defines as undefined behaviour calling twice the
_startsymbol of the same module instance. Equivalently, this means that WASM leaves the instance in an unusable state after execution. This helped catch a bug in threaded execution in faabric.See faasm/cpp#109