Updates for nng-based faabric branch #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a5eb4f to
1e7a2d0
Compare
csegarragonz
approved these changes
Nov 30, 2022
Collaborator
csegarragonz
left a comment
There was a problem hiding this comment.
LGTM after faabric's PR is merged in.
This is quite a big change, with potentially performance differences. I wonder if it is worth making a new minor Faasm tag 🤔
@eigenraven do you have all the permissions to trigger a tag upgrade?
Shillaker
approved these changes
Dec 13, 2022
Collaborator
|
@eigenraven FYI I have merged faabric, updated the submodule, and bumped the code version to trigger a new tag build. Will merge the PR in after all checks pass (we need the new docker images to be available before being able to run the tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short: thread-safe sockets to reduce socket creation inside worker threads. See faasm/faabric#286 for all the details.
Requires the faabric PR to be merged first to update the submodule pointer.