Remove BOOST_NO_TYPEID which snuck back in during one of the PR merges
#691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
approved these changes
Oct 31, 2022
Collaborator
csegarragonz
left a comment
There was a problem hiding this comment.
Gah! Sorry, my bad. Thanks for bringing this up!
BOOST_NO_TYPEID which snuck back in during one of the PR merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these 3 lines during experiments with #683, and later removed them with a rebase but they got merged in afterwards from the old version anyway. RTTI is fully enabled in the codebase now, so this is not needed and could lead to odd linker errors (odr violation) in the future.