-
Notifications
You must be signed in to change notification settings - Fork 70
Homogenise git and docker interface
#679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
approved these changes
Oct 3, 2022
61597d7 to
a6f6bc3
Compare
a6f6bc3 to
b1a5a12
Compare
21cdbe1 to
b07abaa
Compare
b07abaa to
2c875d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third of a three-part PR that implements the following changes in
faasm,faabric, andcpp:inv release.*toinv git.*.inv git.bumpinv container.*toinv docker.*inv docker.build. Stick toinv docker.build -c <ctr_name> [-c <ctr_name_2>] [--nocache] [--push]venv-bmfromfaasmto all other repos (a bit unrelated but worth the effort).RUNcommands) in our docker build files. This is recommended in docker's best practices. As always with style guidelines that we can't enforce, it's a bit of a best-effort thing.THIS_DIRresolutionzsh-proof (see Make scripts zsh proof #666).Closes #666
For more background, see faasm/faabric#272.