Fixes for dev cluster environment #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
commented
Mar 16, 2022
| # This env makes sure we mount our local setup into the containers, rather | ||
| # than using the prebuilt binaries | ||
| env = copy(os.environ) | ||
| env["FAASM_BUILD_DIR"] = join(PROJ_ROOT, "dev/faasm/build") |
Collaborator
Author
There was a problem hiding this comment.
FAASM_BUILD_DIR would get set by bin/workon.sh which would pick up the native build dir, not this one.
csegarragonz
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envset up in the task.FAASM_BUILD_DIRin accordance with local dev setup.