SGX-free builds #622
Merged
SGX-free builds #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7519463 to
6aa554e
Compare
csegarragonz
commented
Mar 15, 2022
| clean: | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: "Prune docker" |
Collaborator
Author
There was a problem hiding this comment.
This diff is quite confusing, you can browse the file here.
csegarragonz
commented
Mar 15, 2022
| - name: "Run the tests" | ||
| run: /build/faasm/bin/tests | ||
|
|
||
| sgx-tests: |
Collaborator
Author
There was a problem hiding this comment.
I don't merge this with tests as a single job with a matrix because tests already has the sanitisers matrix, and we only want to run the SGX tests with no sanitisers.
Shillaker
approved these changes
Mar 15, 2022
Collaborator
Shillaker
left a comment
There was a problem hiding this comment.
Awesome, actually a lot cleaner than I thought it would be 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I remove SGX completely from the default (
base,worker,cli) containers. As suggested, I re-purpose thesgx.dockerfileintobase-sgx.dockerfilethat inherits frombasewith SGX installed. As a result, we generate the following new docker images:base-sgx,base-sgx-sim,worker-sgx,worker-sgx-sim,cli-sgx,cli-sgx-sim. All of them are created as a parallelisedReleaseworkflow file with the following stages and dependencies (images in the same column are built in parallel through a matrix):Closes #617