Clean up enclave-related code running outside the enclave #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I re-factor and do some clean-up of the code running outside the enclave (
{src,include}/enclave/outside).Changelog:
SGXWamrWasmModule.{cpp,h}toEnclaveInterface.{cpp,h}: as discussed offline, the real WASM module is inside the enclave, so this name was misleading.SGXWAMRWasmModule.StogetSgxSupport.S: the name for theASMscript was also very misleading. This file checks for HW support for SGX. There are other ways to do it (not necessarily less involved), but in any case matter for a different PR.EnclaveInterface.htoecalls.hfor clarity. Note that ECalls are declared outside the enclave, but defined inside*.*This is not entirely true, as SGX generates stubbed calls using the
EDGER8Rtool, so a sort of ECall is defined outside the enclave as part of the build process. But this is not relevant to the discussion.