Fix Build of Trusted Code in SGX #592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part of the code meant to run inside the enclave (
src/enclave/inside) is only used as an API through theECallinterface. As a consequence, no CMake target (other thanenclave_trusted) would trigger the build of the trusted side, and the enclave was not getting re-built (i.e. it was not there in clean builds).To dive in a bit deeper, enclave code (i.e. the
enclave_trustedtarget in CMake) gets built into a signed library as apost_targetcommand. Source code elsewhere just assumes that the library will be there at runtime (path is hardcoded).There used to be an
add_dependencyin the original CMake, but I dropped it in the re-factoring process in #588.I also fix a compilation issue that had slipped because of this.