Disable SGX *only* when sanitisers on #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f56145 to
a2eef1a
Compare
Collaborator
|
It looks as though it was not finding SGX because it was not actually trying to find the package, as |
a2eef1a to
56f0dec
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running sanitisers we switch off SGX, but it seems as though the logic switches of SGX even when we're not running sanitisers. This means that the
enclavedirectory wasn't getting compiled, and tests weren't running in theNonepart of the matrix (i.e. tests were not running in GHA at all), and compilation errors were only picked up in thedist-testbuild.It also looks like the build isn't finding SGX in the GHA environment, see the output of the
conan-cachestep in this run, which now prints "SGX not found" in step to build dev dependencies.