SGX: Re-run tests again as part of GHA. #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Feb 14, 2022
| prof=False, | ||
| sanitiser="None", | ||
| nosgx=True, | ||
| nosgx=False, |
Collaborator
Author
There was a problem hiding this comment.
If we set this by default to True, I have found no way to re-enable SGX from the CLI.
I think this is because, as a Boolean value, it is interpreted as a flag. You can't set a Flag to False (i.e. not-Flag). Either you set it, or you don't.
Therefore, both setting the flag and not setting it achieve the same result, disabling SGX, and there is no way to enable it.
I suggest we set it to False by default, and then if we don't want SGX we just run --nosgx. Further, we need to build with SGX by default for the tests to run.
Collaborator
There was a problem hiding this comment.
Yes, sorry I think I meant to set it to --nosgx=False by default anyway. As you say, these flags have to have a default of false.
b289b0b to
e860756
Compare
0e46803 to
90157a4
Compare
Shillaker
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SGX execution, broken after the removal of
checkSgxSetup()in faabric.Make sure we are running SGX tests as part of our GHA pipelines.