Update to use new Faabric dirty tracking #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
commented
Jan 6, 2022
| CONAN_CACHE_MOUNT_SOURCE: ~/.conan/ | ||
| - name: Get Conan Version - Show Log | ||
| if: always() | ||
| run: cat /tmp/conan-ver-log |
Collaborator
Author
There was a problem hiding this comment.
This was broken and the caching wasn't working before, now it does AFAICT.
Shillaker
commented
Jan 6, 2022
| FetchContent_Declare(wavm_ext | ||
| GIT_REPOSITORY "https://github.com/faasm/WAVM.git" | ||
| GIT_TAG "faasm" | ||
| GIT_TAG "2434b3b170404b63afbd2103eecbf510dd1665f4" |
Collaborator
Author
There was a problem hiding this comment.
This update is crucial and I don't trust using a branch name in FetchContent.
Shillaker
commented
Jan 6, 2022
| ./bin/cli.sh faasm | ||
|
|
||
| # Faabric | ||
| ./bin/cli.sh faabric |
Collaborator
Author
There was a problem hiding this comment.
No longer in this repo. Done directly in Faabric checkout.
Shillaker
commented
Jan 6, 2022
| # Build CPP functions and lib required for the tests | ||
| inv func.local | ||
| inv libfake | ||
| inv func.local libfake |
Collaborator
Author
There was a problem hiding this comment.
Changed these to one-liners to be more copy-pasteable
Shillaker
commented
Jan 6, 2022
| return std::span<uint8_t>(memBase, currentSize); | ||
| } | ||
|
|
||
| static std::string getAppSnapshotKey(const faabric::Message& msg) |
Collaborator
Author
There was a problem hiding this comment.
All of this logic has been moved into the Executor class in Faabric now.
Shillaker
commented
Jan 6, 2022
| // thread number | ||
| m.set_groupidx(i); | ||
| m.set_groupsize(nextLevel->numThreads); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This logic has also been absorbed into the Executor class in Faabric.
csegarragonz
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for Faabric dirty tracking changes in faasm/faabric#210