Skip to content

Conversation

@csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Dec 15, 2021

After going through the docs to build the code outside the container myself, I update some of the instructions that were outdated.

Most importantly, we must be able to hit S3 from outside the container, thus we need to publish the S3 ports in docker-compose.yml.

If this is not worth doing only for out-of-container builds (as they are not recommended) I can amend the docs indicating the changes that need to be done to the compose file, and maybe add a sed onliner.

@csegarragonz csegarragonz self-assigned this Dec 15, 2021
@csegarragonz csegarragonz merged commit 01829f3 into master Dec 16, 2021
@csegarragonz csegarragonz deleted the update-dev-docs branch December 16, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants