Updates for out-of-container builds #550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After going through the docs to build the code outside the container myself, I update some of the instructions that were outdated.
Most importantly, we must be able to hit S3 from outside the container, thus we need to publish the S3 ports in
docker-compose.yml.If this is not worth doing only for out-of-container builds (as they are not recommended) I can amend the docs indicating the changes that need to be done to the compose file, and maybe add a
sedonliner.