Snapshot and shared memory updates #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
commented
Dec 13, 2021
bin/workon.sh
Outdated
| export ASAN_OPTIONS="halt_on_error=1" | ||
| export LSAN_OPTIONS="suppressions=${PROJ_ROOT}/leak-sanitizer-ignorelist.txt" | ||
| export TSAN_OPTIONS="halt_on_error=1:suppressions=${PROJ_ROOT}/thread-sanitizer-ignorelist.txt:history_size=7:second_deadlock_stack=1" | ||
| export UBSAN_OPTIONS="print_stacktrace=1:halt_on_error=1" |
Collaborator
Author
There was a problem hiding this comment.
This was previously listed in the dev set-up instructions where it will inevitably rot and must be copy-pasted regularly. Here it's set up by default. Didn't think this was worth a separate PR but can change.
Shillaker
commented
Dec 21, 2021
Shillaker
commented
Dec 28, 2021
csegarragonz
requested changes
Dec 28, 2021
Collaborator
csegarragonz
left a comment
There was a problem hiding this comment.
LGTM. Just minor comments re.std::byte and atomic variables. Also a reminder to finish off and merge the faabric PR first.
csegarragonz
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new Faabric snapshots faasm/faabric#176 faasm/faabric#201
Support use of new CPP markup faasm/cpp#71
Closes #545