Add distributed tests for MPI #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
requested changes
Nov 15, 2021
| msg.set_mpiworldsize(4); | ||
|
|
||
| // Call the functions | ||
| sch.callFunctions(req); |
Collaborator
There was a problem hiding this comment.
It would be nice to somehow test that these had been executed on different hosts. Could we perhaps check the execution graph? Would be a nice indirect test of that working in a distributed environment too.
Collaborator
Author
There was a problem hiding this comment.
Yes, I think this is a very valid point. I add a utility function in faasm/faabric#178 and then check for it here.
069e14c to
9571ff1
Compare
2d7fd71 to
60308b2
Compare
csegarragonz
commented
Nov 23, 2021
| @@ -1,4 +1,4 @@ | |||
| FROM faasm/faabric-base:0.2.0 | |||
Collaborator
Author
There was a problem hiding this comment.
This was needed to merge the latest conan changes in faabric.
Shillaker
approved these changes
Nov 24, 2021
60308b2 to
efe985a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I include two distributed tests for MPI.
I also bump the code version to re-build the containers as required in faasm/faabric#177.