Cmake cleanup Faasm Part 2 #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90bbf3c to
4cad71c
Compare
4cad71c to
45d736c
Compare
45d736c to
f5d93f5
Compare
Shillaker
requested changes
Oct 27, 2021
Collaborator
Shillaker
left a comment
There was a problem hiding this comment.
Overall looks great, couple of small (potential) changes and checks, then once tests have gone through I think it's good to go 👍
Collaborator
Author
|
Due to the bad copy-paste between conf and codegen the container build failed, so I'm restarting it but also now building base and cli locally so that the tests can run earlier |
07ab632 to
a0ce53a
Compare
a0ce53a to
b83f932
Compare
* WAVM was linking LLVM dynamically while WAMR was doing it statically, resulting in a conflict of static constructors * dist_test_server was linking to test_utils->Catch2, but it didn't use any of its functions, so the correct symbols never got placed in the executable, and the linker complained about not being able to find Catch2 symbols referenced by the faabric test_utils shared library
…ogs to trigger GH Actions log rate limiter
fdc3c27 to
95716df
Compare
95716df to
96d32a8
Compare
Shillaker
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before ready for merging, needs #522 and faasm/faabric#165 - then dockerfiles must be pointed at the new base containers.
Closes #413