Skip to content

Conversation

@Shillaker
Copy link
Collaborator

@Shillaker Shillaker commented Oct 14, 2021

When diffing snapshots, we don't need to include changes in either the wasm stack or thread stacks (as these are only useful to the locally executing thread(s)).

To enforce this, this PR adds ignore regions to the underlying snapshots covering both stack regions.

Changes:

  • Add ignore regions to snapshots before executing wasm modules (this is the only time we know both where the stacks will be, and which snapshot will be used).
  • Add test to check that diffs in the stacks are ignored, but not the heap.

@Shillaker Shillaker self-assigned this Oct 15, 2021
@Shillaker Shillaker force-pushed the ignore-thread-stacks branch from 4c04419 to 43c767f Compare October 18, 2021 07:39
@Shillaker Shillaker changed the title Add ignore region for thread stacks Add snapshot ignore region for wasm stack and thread stacks Oct 19, 2021
@Shillaker Shillaker marked this pull request as ready for review October 19, 2021 12:50
@Shillaker Shillaker removed the request for review from csegarragonz October 19, 2021 13:06
@Shillaker Shillaker merged commit 9a69ffd into master Oct 20, 2021
@Shillaker Shillaker deleted the ignore-thread-stacks branch October 20, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants