Use snapshots in module reset (rather than memcpy) #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an executor completes a function execution it calls
reseton a Faaslet, which in turn callsreseton the wasm module.A while ago I switched WAVM-based wasm modules to use a "base snapshot" to restore during
reset, which avoids doing a (slow) memcpy of the whole memory. However, in PR #411 I accidentally removed this, so all WAVM-based wasm modules are doing a full memcpy at the end of each execution (as noted by @KubaSz offline).This restores the snapshotting, which greatly reduces the
resettime for modules, but does so at a per-function level in the Faaslet itself, which makes it potentially reusable in WAMR-based wasm modules too.