Update SGX build files #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Oct 8, 2021
src/sgx/CMakeLists.txt
Outdated
| # NASM configuration | ||
| enable_language(ASM_NASM) | ||
| set(CMAKE_ASM_NASM_FLAGS -felf64) | ||
| set(CMAKE_ASM_NASM_COMPILE_OBJECT "<CMAKE_ASM_NASM_COMPILER> <INCLUDES> ${CMAKE_ASM_NASM_FLAGS} -o <OBJECT> <SOURCE>") |
Collaborator
Author
There was a problem hiding this comment.
The diff is quite gnarly, so you may as well directly check the source file here. You may request any change at all in the file (not just comitted changes) as I have basically tinkered with every bit of it.
ca30e67 to
5197644
Compare
Shillaker
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I update the build files and build flags related to SGX. In particular:
CMakeListsto make them more readable.FAASM_SGX_ATTESTATIONmacro: even though we keep thesgx/attestation.{c,h}for reference, we elsewhere keep the branch ofFAASM_SGX_ATTESTATION = 0.The attestation bit will be updated once we merge in the new attesation mechanism.