scheduler: tag executors with app id #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus far, we tagged executors with the (user, function) pair. This is needed in multi-threaded environments, where different threads must share the same executor. However, using only the (user, function) pair prevents the execution concurrent applications with the same pair. Instead, the correct thing to do is to track applications using the (user, function) pair in conjunction with the application id.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 117 117
Lines 8233 8233
=======================================
Hits 6696 6696
Misses 1537 1537 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus far, we tagged executors with the (user, function) pair. This is needed in multi-threaded environments, where different threads must share the same executor. However, using only the (user, function) pair prevents the execution concurrent applications with the same pair.
Instead, the correct thing to do is to track applications using the (user, function) pair in conjunction with the application id.