-
Notifications
You must be signed in to change notification settings - Fork 14
Route callFunctions through the planner
#345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60dea3e to
464e6dd
Compare
464e6dd to
61e39e9
Compare
8970f70 to
5f8583f
Compare
…of messages sent to avoid race conditions
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 82.35% 81.40% -0.95%
==========================================
Files 103 102 -1
Lines 8183 7857 -326
==========================================
- Hits 6739 6396 -343
- Misses 1444 1461 +17
|
c6fd88e to
f3fbee4
Compare
…t, as we already release them when making the decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we make the planner take the scheduling decisions in a centralized manner. Intuitively, this means that the
callFunctionsmethod is moved from theSchedulerto thePlannerClient.This PR finalizes most of the work to move from a decentralised to a centralized scheduler, and it includes some relevant changes in functionality (for the tests mostly):
callFunctionsbutexecuteBatchorexecuteThreads).This PR also removes a lot of functionality from the
Schedulerclass. This class had become very overloaded, and now is almost unnecessary. In subsequent PRs I will separate theExecutorfrom theSchedulerand decide exactly how to rename the remainders of the Scheduler.Closes #275
Closes #287