Move message result management to PlannerClient
#340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlannerClient
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 82.04% 81.81% -0.24%
==========================================
Files 98 98
Lines 7972 7966 -6
==========================================
- Hits 6541 6517 -24
- Misses 1431 1449 +18
|
…o avoid undefined behaviours
…odate for its async behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message results are managed by the planner, so there's no need for the setting/getting of those messages to be part of the
Schedulerclass.Instead, in this PR I move them to the
PlannerClient. Getting/setting a message involves, most of the times, to just sending a request to thePlannerServer. To implement client-side blocking we have a small message result cache, which we also integrate in the PlannerClient.