Refactor getMessageResult signature
#308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getMessageResult signaturegetMessageResult signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I refactor the signature of the
getMessageResultfunction in the scheduler to take aconst Message&. This makes the signature symmetric tosetFunctionResult.All the changes are mostly straightforward, with the expection of chained functions. We neeed to support waiting for chained functions by their id (as specified in
libfaasmfor WASM code), so we keep track of the chained messages in the executor.Right now, this does not add any functionality but, once the planner PRs land, it will allow to do things like wait for all messages in a batch request (i.e. implementing a get/set Batch result).