Various MPI fixes #264
Merged
Various MPI fixes #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
May 13, 2022
| checkAllocationAndResult(req); | ||
| } | ||
|
|
||
| TEST_CASE_METHOD(MpiDistTestsFixture, "Test MPI all to all many times", "[mpi]") |
Collaborator
Author
There was a problem hiding this comment.
This distributed test fails in the current main branch.
3818ec1 to
df93eef
Compare
Too many open files problem in ZeroMQdf93eef to
689da21
Compare
csegarragonz
commented
May 20, 2022
| // collective communications by all ranks. At this point, all non- | ||
| // leader ranks will be hitting a barrier, for which they don't | ||
| // need the ranks for host map, therefore it is safe to modify it | ||
| if (m.dsthost() == thisHost && m.msg().mpirank() < localLeader) { |
Collaborator
Author
There was a problem hiding this comment.
We used to call initLocalRemote() here, unfortunately that method is too coarse and was clearing the rankForHost structure before filling it again.
This was causing a race condition between migrated and non-migrated ranks.
csegarragonz
commented
May 20, 2022
src/scheduler/ExecGraph.cpp
Outdated
| return getMpiRankHostsFromExecGraphNode(graph.rootNode); | ||
| } | ||
|
|
||
| void getMigratedMpiRankHostsFromExecGraph(const ExecGraph& graph, |
Collaborator
Author
There was a problem hiding this comment.
Moved this method here so I can use it for Faasm tests as well.
Shillaker
requested changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix a couple of issues that I ran into whilst reproducing the MPI results.
Too many files openerror in ZeroMQ #266. The current solution is only a patch, and we should address it properly in a separate PR.UNDERFULLtopology hint in MPI to deliberately missplace MPI functions for a migration opportunity to appear.