Cmake cleanup Faabric Part 1 #162
Conversation
Keeping old versions during transition to newer toolchain
Shillaker
left a comment
There was a problem hiding this comment.
Nice, very tactical. Just a couple of small requests.
docker/faabric-base.dockerfile
Outdated
| RUN apt-get update | ||
|
|
||
| RUN apt install -y \ | ||
| ansible \ |
There was a problem hiding this comment.
This is now a pretty long list, is everything here essential for Faabric?
The container images are already pretty bloated, and having two versions of LLVM will definitely bump that up as it is 😄 .
If people need extra dependencies for development they can create their own containers and set the FAABRIC_CLI_IMAGE and FAASM_CLI_IMAGE respectively. Any Faasm-only dependencies should go into the Faasm Dockerfiles.
Things that immediately stick out are: ansible, cgroup-tools, gdb, g++-11, iproute, iptables, libcgroup-dev, zsh.
There was a problem hiding this comment.
Ah I forgot to cut out a few of these, g++-11 is useful for the newer libstdc++ to get detected properly by clang, I have no idea what black magic clang uses to pick the version of its c++ libraries. The rest are here because I merged in the dependencies of cpp-root into here, so that faasm would base on faabric-base and everything gets installed in one layer, but noting your concerns about not rebuilding this container often I'll move them back to cpp-root
|
Replaced by #164 |
This updates the faabric-base image with the newer C++20-ready toolchain, Conan and up-to-date CMake from Kitware APT repository. Also minor fixes (missing #includes) to compilation errors uncovered by using a newer libstdc++. And a tweak to workon.sh so that it actually installs the pip requirements. A faabric version bump and pointing the dockerfile to the new faabric-base will be required after this.