add!: proper sub commands for bump and log commands #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

f3ath merged 6 commits into f3ath:master from marvin-kolja:sub-commands

Jan 31, 2024

Contributor

marvin-kolja commented Jan 29, 2024

Closes #69


          add!: proper sub commands for bump and log commands

86e6594

f3ath reviewed

View reviewed changes

lib/src/cli/command/bump_command.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

lib/src/cli/command/log_command.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

test/functional_test.dart Outdated Show resolved Hide resolved

marvin-kolja added 3 commits

January 30, 2024 08:32


          refactor: move sub-command props into enum

379fb6c


          fix: use Console out channel to print usage instead of print

d1eb32c


          test: bump and log usage output test

94fd222

f3ath reviewed

View reviewed changes

lib/src/cli/command/bump_command.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

lib/src/cli/command/bump_sub_command.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

lib/src/cli/command/bump_sub_command.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

lib/src/cli/command/log_sub_command.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

test/functional_test.dart Outdated Show resolved Hide resolved

f3ath reviewed

View reviewed changes

test/functional_test.dart Outdated Show resolved Hide resolved

Owner

f3ath commented Jan 31, 2024

Great job. We're pretty close. Just a few nitpicking comments really.

marvin-kolja added 2 commits

January 31, 2024 02:36


          chore: use first instead of [0]

47dc736


          chore: use positional args instead of named ones

c78bc18

marvin-kolja requested a review from f3ath

January 31, 2024 01:49

f3ath merged commit e1e59c7 into f3ath:master

Owner

f3ath commented Jan 31, 2024

Thank you!

marvin-kolja mentioned this pull request

refactor: rename 'printer' variable to 'console' #71

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet