fix: undefined array key warning#419
Merged
ezyang merged 1 commit intoezyang:masterfrom Oct 31, 2024
Merged
Conversation
Contributor
Author
|
@ezyang When do you plan to make the release? I need to have this change in the release, is there a way to make it? :) |
Owner
|
i forgot how to make a new release again lol |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
# [4.18.0](v4.17.0...v4.18.0) (2024-11-01) ### Bug Fixes * Adjust Core.AllowHostnameUnderscore to consider that "_" is defined as Unreserved Characters in RFC 3986 ([#406](#406)) ([d9fbef8](d9fbef8)) * Avoid a deprecated error when the attribute name is numeric and DirectLex is used ([#412](#412)) ([f0fbf51](f0fbf51)) * checking that node has property name ([#399](#399)) ([9ca5a36](9ca5a36)) * Ignore conditional comments ([#401](#401)) ([4828fdf](4828fdf)) * Support PHP 8.4 ([#396](#396)) ([92da247](92da247)) * undefined array key warning ([#419](#419)) ([01be377](01be377)) ### Features * Add allowfullscreen attr for iframe ([#411](#411)) ([70754a2](70754a2)) * add directive for removing blank nodes ([#404](#404)) ([c9d60c9](c9d60c9)) * Add support for CSS aspect-ratio ([#408](#408)) ([93bee73](93bee73)) * Allow universal CSS values for all properties ([#410](#410)) ([9723267](9723267))
|
🎉 This PR is included in version 4.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
The following code causes the warning “Undefined array key 2”
This also solves the problem reported here #413