fix: add back noErrors = false to emitSkipped#381
Merged
Conversation
- apparently `emitSkipped` can indeed happen without there being a semantic or syntactic error - so add back the previous unconditional behavior of `noErrors` - still not clear what exactly triggers `emitSkipped` though, see my TS issue
Collaborator
Author
|
Oh... well I didn't quite realize this (was refactoring/simplifying this code a bit after all), but this is totally redundant because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
noErrors = falseunconditional again inemitSkippedtypecheckFilefunc #344 (comment)Details
apparently
emitSkippedcan indeed happen without there being a semantic or syntactic errornoErrorsstill not clear what exactly triggers
emitSkippedthough, see my TS issue Document whenemitSkippedistruein Compiler API microsoft/TypeScript#49790