refactor: invert another if for readabilty -- in get-options-overrides#348
Merged
Merged
Conversation
- my previous commit was mostly focused on index.ts, this one is for get-options-overrides -- in general, I'm just trying to make old code more readable as I come across and then realize that the code can be re-written better, or, in this case, a conditional inverted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invert an
ifconditional inget-options-overridesfor readabilityDetails
index.ts, this one is forget-options-overrides-- in general, I'm just trying to old code more readable as I come across and then realize that the code can be re-written better, or, in this case, a conditional invertedReview Notes
This one's not a big improvement either way and not a complete inversion (it's just an early return of the same final return), so also feel free to reject this. I don't feel strongly about it, but figured I might as well rewrite it to follow the same kind of style found elsewhere