Skip to content

docs: Change @rollup/plugin-typescript link#307

Closed
dev-itsheng wants to merge 2 commits into
ezolenko:masterfrom
dev-itsheng:patch-1
Closed

docs: Change @rollup/plugin-typescript link#307
dev-itsheng wants to merge 2 commits into
ezolenko:masterfrom
dev-itsheng:patch-1

Conversation

@dev-itsheng

Copy link
Copy Markdown

I noticed that the previous link did not exist anymore, after a search it was moved to a new location, so I changed the link.

I noticed that the previous link did not exist anymore, after a search it was moved to a new location, so I changed the link.
@ezolenko

Copy link
Copy Markdown
Owner

Thanks, this change makes the text not quite correct though -- this repo was started from a specific fork that was later deleted by its author (and the source repo was moved to new location as you found). That's why the link doesn't work.

Maybe change to something like this:

This is a rewrite of original [rollup-plugin-typescript](https://github.com/rollup/plugins/tree/master/packages/typescript), starting and borrowing from a fork by `alexlur`.

@dev-itsheng

Copy link
Copy Markdown
Author

That is, its roadmap looks like this:

A rollup-plugin-typescript(rollup/rollup-plugin-typescript) ----> D @rollup/plugin-typescript(rollup/olugins)
   ↓
B rollup-plugin-typescript(alexlur/rollup-plugin-typescript)
   ↓
C rollup-plugin-typescript2(this repo)

A is still there, but its GitHub README is declared read-only and no longer maintained, and needs to be migrated to D, and B has been removed.

I thought about it carefully and decided to clarify the relationship between them and change it to what it is now.

@agilgur5 agilgur5 added the scope: docs Documentation could be improved. Or changes that only affect docs label May 3, 2022
@ezolenko ezolenko closed this Jun 7, 2022
Comment thread README.md
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Jul 10, 2022
@agilgur5 agilgur5 added kind: discussion Discussion on changes to make kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc and removed kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs labels Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: discussion Discussion on changes to make kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc scope: docs Documentation could be improved. Or changes that only affect docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants