-
Notifications
You must be signed in to change notification settings - Fork 232
# Asset Dependency Overhaul #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Asset Package References * Added **ezDependencyFlags** which defines how a reference in an asset is used: * **Thumbnail**: This reference is a dependency to generating a thumbnail. * **Transform**: This reference is a dependency to transforming this asset. * **Package**: This reference is needs to be packaged as it is used at runtime by this asset. * **ezAssetBrowserAttribute** now has a new parameter to set the `ezDependencyFlags` for it. By default, **ezDependencyFlags::Thumbnail | ezDependencyFlags::Package** is set. * Fixed naming of various enums and member variables to match the new `transform`, `thumbnail` and `package` dependency naming pattern. ## Circular Dependencies * Circular dependencies will no longer deadlock the editor and instead result in a new error code on one of the assets in the circle: **ezAssetInfo::TransformState::CircularDependency**. * **ezAssetCurator::GenerateTransitiveHull** is no longer recursive and can handle circular dependencies. * Added **ezAssetCurator::GenerateInverseTransitiveHull** which generates a set of all assets that depend in the given asset. Used by the new **ezAssetCurator::CheckForCircularDependencies** function. * **ezAssetCurator::InvalidateAssetTransformState** is no longer recursive, using **GenerateInverseTransitiveHull** instead. * **ezQtAssetPropertyWidget::InternalSetValue** will prevent the user now from creating circular dependencies. ## Misc * Added **Asset.WriteDependencyDGML** action which creates a DGML file containing all transform and thumbnail dependencies this asset transitively depends on. Very useful to understand circular dependencies. * Added **ezAssetActions::MapMenuActions** to put `Transform Asset` and `Write Dependency DGML` into the edit menu. * **ezCollectionAssetDocument** are no longer updated automatically as their transitive naturure can't be tracked correctly by the currently defined `ezDependencyFlags`. Instead, they are set to manual transform and will be auto-generated on every scene export.
jankrassnigg
approved these changes
Mar 20, 2023
Code/Editor/EditorFramework/Assets/Implementation/AssetWatcher.cpp
Outdated
Show resolved
Hide resolved
Code/Engine/Foundation/Reflection/Implementation/PropertyAttributes.h
Outdated
Show resolved
Hide resolved
Code/Engine/Foundation/Reflection/Implementation/PropertyAttributes.h
Outdated
Show resolved
Hide resolved
Member
|
This also fixes #580. |
jankrassnigg
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset Package References
ezDependencyFlagsfor it. By default, ezDependencyFlags::Thumbnail | ezDependencyFlags::Package is set.transform,thumbnailandpackagedependency naming pattern.Circular Dependencies
Misc
Transform AssetandWrite Dependency DGMLinto the edit menu.ezDependencyFlags. Instead, they are set to manual transform and will be auto-generated on every scene export.