Added compile time version of xxHash32. #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Core
approved these changes
Jul 13, 2020
Member
C-Core
left a comment
There was a problem hiding this comment.
Looks good, surprisingly uncomplicated, compilers seem to accept a lot more complicated code as constexpr nowadays.
Member
|
WOW! That was fast! 👍 That means we can replace the MurmurHash in ezHashedString with xxHash now. Any reason to keep MurmurHash around, at all? Are there any situations where it might still be preferable? |
jankrassnigg
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes small VS2019 16.6.2 build fix.