Small Build System Cleanup #225

Ingrater · 2020-05-13T20:15:01Z

Seperate the concepts of generator, target architecture and compiler. This allows to compile for a single target platform with multiple compilers. For example its now possbile to compile with clang on windows.
Add better detection of target architecture by actually invoking the compiler instead of relying on cmake quirks.
Cleanup handling of warnings for msvc. Do not ignore them through header files, instead ignore them through compiler options. This doesn't leak the ezEngine warning settings to customers.
Adds propper support for VS 2019. Fixes Buildsystem cannot distinguish VS 2017 and VS 2019 #223

…g on cmake quirks.

…der files, instead ignore them through compiler options. This doesn't leak the warning ignores to customers.

jankrassnigg · 2020-05-13T20:28:51Z

Do not ignore them through header files, instead ignore them through compiler options.

😄

Code/BuildSystem/ProbingSrc/ArchitectureDetect.c

Code/Engine/Foundation/Basics/Platform/DetectArchitecture.h

Code/Engine/Foundation/Basics/Platform/Win/Platform_win.h

Code/Engine/Texture/DirectXTex/DirectXTexMipmaps.cpp

Code/EnginePlugins/TypeScriptPlugin/TsBinding/TsGameObject.cpp

jankrassnigg · 2020-05-13T20:45:23Z

Code/UnitTests/FoundationTest/SimdMath/SimdFloatTest.cpp


    // Make sure all components are set to the same value
-#if EZ_SIMD_IMPLEMENTATION == EZ_SIMD_IMPLEMENTATION_SSE
+#if (EZ_SIMD_IMPLEMENTATION == EZ_SIMD_IMPLEMENTATION_SSE) && EZ_ENABLED(EZ_COMPILER_MSVC)


Why is this stuff MSVC specific?
@C-Core

Only MSVC defines __m128 as a union. On clang and gcc __m128 is a opaque data type with no members. Thats why all these tests only work on msvc.

jankrassnigg · 2020-05-13T20:47:21Z

Why do you need to check in a binary file (.o) ?

Code/BuildSystem/CMake/ezUtilsDetect.cmake

jankrassnigg

Awesome! This is a really great improvement!

Ingrater · 2020-05-14T06:47:11Z

Why do you need to check in a binary file (.o) ?

Adding this file was unintentional. Will remove.

…same casing as in original source)

Ingrater added 3 commits May 11, 2020 17:41

Add better detection of compiler & target architecture without relyin…

27f9add

…g on cmake quirks.

Make ezEngine compile with clang on windows.

4504a7c

Cleanup handling of warnings for msvc. Do not ignore them through hea…

c5edbae

…der files, instead ignore them through compiler options. This doesn't leak the warning ignores to customers.

Ingrater requested a review from jankrassnigg May 13, 2020 20:15