Ralph/chore/fix.coderabbit.issues by Crunchyman-ralph · Pull Request #1432 · eyaltoledano/claude-task-master

Crunchyman-ralph · 2025-11-21T11:16:20Z

What type of PR is this?

Description

Related Issues

How to Test This

# Example commands or steps

Expected result:

Contributor Checklist

Created changeset: npm run changeset
Tests pass: npm test
Format check passes: npm run format-check (or npm run format to fix)
Addressed CodeRabbit comments (if any)
Linked related issues (if any)
Manually tested the changes

Changelog Entry

For Maintainers

PR title follows conventional commits
Target branch correct
Labels added
Milestone assigned (if applicable)

Summary by CodeRabbit

Refactor
- Standardized parameter handling across server tools for more consistent behavior.
Bug Fixes
- Safer task retrieval to avoid missing-data errors.
- More consistent error propagation for task operations.
Documentation
- Updated autopilot tool descriptions to clarify phase handling (COMMIT directed to commit tool; RED/GREEN behavior clarified).
Chores
- Minor code organization and small readability improvements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2025-11-21T11:16:24Z

⚠️ No Changeset found

Latest commit: 4946c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-11-21T11:16:31Z

Walkthrough

Refactors many MCP server tools to call handleApiResult with a single options object (result, log, errorPrefix, projectRoot); updates autopilot complete tool description; centralizes task array null-safety in get-tasks; caches tasks path in parse-prd command; minor comment removal.

Changes

Cohort / File(s)	Summary
handleApiResult refactor (many tools) `mcp-server/src/tools/{add-subtask.js,add-tag.js,add-task.js,analyze.js,clear-subtasks.js,complexity-report.js,copy-tag.js,delete-tag.js,expand-all.js,expand-task.js,fix-dependencies.js,initialize-project.js,list-tags.js,models.js,move-task.js,next-task.js,parse-prd.js,remove-dependency.js,remove-subtask.js,remove-task.js,rename-tag.js,research.js,scope-down.js,scope-up.js,set-task-status.js,update-subtask.js,update-task.js,update.js,use-tag.js`	Replaced positional handleApiResult(...) calls with a single object argument: `handleApiResult({ result, log, errorPrefix: '...', projectRoot: args.projectRoot })`.
Autopilot complete tool description `apps/mcp/src/tools/autopilot/complete.tool.ts`	Removed explicit COMMIT handling from the description and directs users to use the separate `autopilot_commit` tool; RED/GREEN semantics remain described.
Task fetching null-safety `apps/mcp/src/tools/tasks/get-tasks.tool.ts`	Introduced local `const tasks = result.tasks ?? []` and switched downstream uses to this local variable for consistent null-safe handling.
Parse-prd command minor optimization `scripts/modules/commands.js`	Cached `taskMaster.getTasksPath()` result into `tasksPath` and reused it for `readJSON`, avoiding repeated lookups.
Minor cleanup `mcp-server/src/tools/get-operation-status.js`	Removed an inline comment on the import line; no behavior change.
Task service error handling change `packages/tm-core/src/modules/tasks/services/task-service.ts`	Unified catch handling: rethrow TaskMasterError instances unchanged; wrap unknown errors consistently with new TaskMasterError messages.

Sequence Diagram(s)

sequenceDiagram
    participant Tool as Tool (mcp-server tool)
    participant Handler as handleApiResult(options)

    Note over Tool: Previously called handleApiResult(result, log, msg, undefined, projectRoot)

    Tool->>Handler: handleApiResult({ result, log, errorPrefix: '...', projectRoot: args.projectRoot })
    Handler-->>Tool: standardized response (success|error)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Areas to focus on:
- Confirm handleApiResult implementation/signature was updated to accept the options object and fields names match (result, log, errorPrefix, projectRoot).
- Inspect move-task.js for additional structural changes and unified response shapes.
- Verify no accidental changes to error propagation semantics across tools (especially where undefined placeholder was previously used).
- Validate packages/tm-core task-service catch behavior to ensure intended rethrow/wrapping logic.

Possibly related PRs

feat: implement local-only command checkers for cli and mcp #1426 — related changes to MCP tool invocation patterns and ToolContext/withToolContext usage; overlaps handleApiResult refactor.
feat: handle new command errors better #1318 — touches task-service error-handling behavior; may conflict with unified catch changes.
Task 104: Implement 'scope-up' and 'scope-down' CLI Commands for Dynamic Task Complexity Adjustment #1069 — edits to scope-up/scope-down tools which are part of the handleApiResult refactor set.

Suggested reviewers

eyaltoledano

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Ralph/chore/fix.coderabbit.issues' is vague and uses branch naming conventions rather than describing the actual changes made in the PR.	Replace the title with a clear, descriptive summary of the main changes, such as 'Refactor handleApiResult to accept object parameters' or 'Update tool descriptions and parameter patterns'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 96.88% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ralph/chore/fix.coderabbit.issues

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98a23f3 and 4946c0f.

📒 Files selected for processing (3)

mcp-server/src/tools/parse-prd.js (1 hunks)
packages/tm-core/src/modules/tasks/services/task-service.ts (4 hunks)
scripts/modules/commands.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

scripts/modules/commands.js
mcp-server/src/tools/parse-prd.js

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1069
File: .changeset/fix-tag-complexity-detection.md:0-0
Timestamp: 2025-08-02T15:33:22.656Z
Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1178
File: packages/tm-core/src/subpath-exports.test.ts:6-9
Timestamp: 2025-09-03T12:45:30.724Z
Learning: The user Crunchyman-ralph prefers to avoid overly nitpicky or detailed suggestions in code reviews, especially for test coverage of minor import paths. Focus on more substantial issues rather than comprehensive coverage of all possible edge cases.

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: scripts/modules/task-manager/parse-prd.js:226-226
Timestamp: 2025-07-20T01:35:05.831Z
Learning: The parsePRD function in scripts/modules/task-manager/parse-prd.js has a different parameter structure than other task-manager functions - it uses `options` parameter instead of `context` parameter because it generates tasks from PRD documents rather than operating on existing tasks.

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: mcp-server/src/tools/agent-llm.js:1-3
Timestamp: 2025-10-12T11:06:36.374Z
Learning: The agent_llm MCP tool in mcp-server/src/tools/agent-llm.js is an exception to the standard MCP tool pattern. It should NOT use handleApiResult because it handles delegated LLM calls rather than direct API calls. Using createErrorResponse for error messages is the correct approach for this tool.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1002
File: .changeset/puny-friends-give.md:2-3
Timestamp: 2025-07-17T21:33:57.585Z
Learning: In the eyaltoledano/claude-task-master repository, the MCP server code in mcp-server/src/ is part of the main "task-master-ai" package, not a separate "mcp-server" package. When creating changesets for MCP server changes, use "task-master-ai" as the package name.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1178
File: packages/tm-core/src/auth/config.ts:5-7
Timestamp: 2025-09-02T21:51:27.921Z
Learning: The user Crunchyman-ralph prefers not to use node: scheme imports (e.g., 'node:os', 'node:path') for Node.js core modules and considers suggestions to change bare imports to node: scheme as too nitpicky.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1132
File: .github/workflows/weekly-metrics-discord.yml:81-93
Timestamp: 2025-08-13T22:10:46.958Z
Learning: Crunchyman-ralph ignores YAML formatting nitpicks about trailing spaces when there's no project-specific YAML formatter configured, preferring to focus on functionality over cosmetic formatting issues.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1132
File: .github/workflows/weekly-metrics-discord.yml:81-93
Timestamp: 2025-08-13T22:10:46.958Z
Learning: Crunchyman-ralph ignores YAML formatting nitpicks about trailing spaces when there's no project-specific YAML formatter configured, preferring to focus on functionality over cosmetic formatting issues.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1200
File: src/ai-providers/custom-sdk/grok-cli/language-model.js:96-100
Timestamp: 2025-09-19T16:06:42.182Z
Learning: The user Crunchyman-ralph prefers to keep environment variable names explicit (like GROK_CLI_API_KEY) rather than supporting multiple aliases, to avoid overlap and ensure clear separation between different CLI implementations.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1105
File: scripts/modules/supported-models.json:242-254
Timestamp: 2025-08-08T11:33:15.297Z
Learning: Preference: In scripts/modules/supported-models.json, the "name" field is optional. For OpenAI entries (e.g., "gpt-5"), Crunchyman-ralph prefers omitting "name" when the id is explicit enough; avoid nitpicks requesting a "name" in such cases.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1217
File: apps/cli/src/index.ts:16-21
Timestamp: 2025-09-18T16:35:35.147Z
Learning: The user Crunchyman-ralph considers suggestions to export types for better ergonomics (like exporting UpdateInfo type alongside related functions) as nitpicky and prefers not to implement such suggestions.

📚 Learning: 2025-09-26T19:10:32.906Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1252
File: tsconfig.json:22-28
Timestamp: 2025-09-26T19:10:32.906Z
Learning: In the eyaltoledano/claude-task-master repository, all internal tm/ package path mappings in tsconfig.json consistently point to TypeScript source files (e.g., "./packages/*/src/index.ts") rather than built JavaScript. This is intentional architecture because tsdown bundles internal packages directly from source during build time, eliminating the need for separate compilation of internal packages.

Applied to files:

packages/tm-core/src/modules/tasks/services/task-service.ts

📚 Learning: 2025-09-26T19:05:47.555Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1252
File: packages/ai-sdk-provider-grok-cli/package.json:11-13
Timestamp: 2025-09-26T19:05:47.555Z
Learning: In the eyaltoledano/claude-task-master repository, internal tm/ packages use a specific export pattern where the "exports" field points to TypeScript source files (./src/index.ts) while "main" points to compiled output (./dist/index.js) and "types" points to source files (./src/index.ts). This pattern is used consistently across internal packages like tm/core and tm/ai-sdk-provider-grok-cli because they are consumed directly during build-time bundling with tsdown rather than being published as separate packages.

Applied to files:

packages/tm-core/src/modules/tasks/services/task-service.ts

🔇 Additional comments (1)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e66150e and 98a23f3.

📒 Files selected for processing (33)

apps/mcp/src/tools/autopilot/complete.tool.ts (1 hunks)
apps/mcp/src/tools/tasks/get-tasks.tool.ts (3 hunks)
mcp-server/src/tools/add-subtask.js (1 hunks)
mcp-server/src/tools/add-tag.js (1 hunks)
mcp-server/src/tools/add-task.js (2 hunks)
mcp-server/src/tools/analyze.js (1 hunks)
mcp-server/src/tools/clear-subtasks.js (1 hunks)
mcp-server/src/tools/complexity-report.js (1 hunks)
mcp-server/src/tools/copy-tag.js (1 hunks)
mcp-server/src/tools/delete-tag.js (1 hunks)
mcp-server/src/tools/expand-all.js (1 hunks)
mcp-server/src/tools/expand-task.js (1 hunks)
mcp-server/src/tools/fix-dependencies.js (1 hunks)
mcp-server/src/tools/get-operation-status.js (1 hunks)
mcp-server/src/tools/initialize-project.js (1 hunks)
mcp-server/src/tools/list-tags.js (1 hunks)
mcp-server/src/tools/models.js (1 hunks)
mcp-server/src/tools/move-task.js (7 hunks)
mcp-server/src/tools/next-task.js (1 hunks)
mcp-server/src/tools/parse-prd.js (1 hunks)
mcp-server/src/tools/remove-dependency.js (1 hunks)
mcp-server/src/tools/remove-subtask.js (1 hunks)
mcp-server/src/tools/remove-task.js (1 hunks)
mcp-server/src/tools/rename-tag.js (1 hunks)
mcp-server/src/tools/research.js (1 hunks)
mcp-server/src/tools/scope-down.js (1 hunks)
mcp-server/src/tools/scope-up.js (1 hunks)
mcp-server/src/tools/set-task-status.js (1 hunks)
mcp-server/src/tools/update-subtask.js (1 hunks)
mcp-server/src/tools/update-task.js (1 hunks)
mcp-server/src/tools/update.js (1 hunks)
mcp-server/src/tools/use-tag.js (1 hunks)
scripts/modules/commands.js (1 hunks)

🧰 Additional context used

🧠 Learnings (37)

📓 Common learnings

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1069
File: .changeset/fix-tag-complexity-detection.md:0-0
Timestamp: 2025-08-02T15:33:22.656Z
Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1178
File: packages/tm-core/src/subpath-exports.test.ts:6-9
Timestamp: 2025-09-03T12:45:30.724Z
Learning: The user Crunchyman-ralph prefers to avoid overly nitpicky or detailed suggestions in code reviews, especially for test coverage of minor import paths. Focus on more substantial issues rather than comprehensive coverage of all possible edge cases.

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: scripts/modules/task-manager/parse-prd.js:226-226
Timestamp: 2025-07-20T01:35:05.831Z
Learning: The parsePRD function in scripts/modules/task-manager/parse-prd.js has a different parameter structure than other task-manager functions - it uses `options` parameter instead of `context` parameter because it generates tasks from PRD documents rather than operating on existing tasks.

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: mcp-server/src/tools/agent-llm.js:1-3
Timestamp: 2025-10-12T11:06:36.374Z
Learning: The agent_llm MCP tool in mcp-server/src/tools/agent-llm.js is an exception to the standard MCP tool pattern. It should NOT use handleApiResult because it handles delegated LLM calls rather than direct API calls. Using createErrorResponse for error messages is the correct approach for this tool.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1178
File: packages/tm-core/src/auth/config.ts:5-7
Timestamp: 2025-09-02T21:51:27.921Z
Learning: The user Crunchyman-ralph prefers not to use node: scheme imports (e.g., 'node:os', 'node:path') for Node.js core modules and considers suggestions to change bare imports to node: scheme as too nitpicky.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1132
File: .github/workflows/weekly-metrics-discord.yml:81-93
Timestamp: 2025-08-13T22:10:46.958Z
Learning: Crunchyman-ralph ignores YAML formatting nitpicks about trailing spaces when there's no project-specific YAML formatter configured, preferring to focus on functionality over cosmetic formatting issues.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1132
File: .github/workflows/weekly-metrics-discord.yml:81-93
Timestamp: 2025-08-13T22:10:46.958Z
Learning: Crunchyman-ralph ignores YAML formatting nitpicks about trailing spaces when there's no project-specific YAML formatter configured, preferring to focus on functionality over cosmetic formatting issues.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1200
File: src/ai-providers/custom-sdk/grok-cli/language-model.js:96-100
Timestamp: 2025-09-19T16:06:42.182Z
Learning: The user Crunchyman-ralph prefers to keep environment variable names explicit (like GROK_CLI_API_KEY) rather than supporting multiple aliases, to avoid overlap and ensure clear separation between different CLI implementations.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1105
File: scripts/modules/supported-models.json:242-254
Timestamp: 2025-08-08T11:33:15.297Z
Learning: Preference: In scripts/modules/supported-models.json, the "name" field is optional. For OpenAI entries (e.g., "gpt-5"), Crunchyman-ralph prefers omitting "name" when the id is explicit enough; avoid nitpicks requesting a "name" in such cases.

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1217
File: apps/cli/src/index.ts:16-21
Timestamp: 2025-09-18T16:35:35.147Z
Learning: The user Crunchyman-ralph considers suggestions to export types for better ergonomics (like exporting UpdateInfo type alongside related functions) as nitpicky and prefers not to implement such suggestions.

📚 Learning: 2025-10-12T11:06:36.374Z

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: mcp-server/src/tools/agent-llm.js:1-3
Timestamp: 2025-10-12T11:06:36.374Z
Learning: The agent_llm MCP tool in mcp-server/src/tools/agent-llm.js is an exception to the standard MCP tool pattern. It should NOT use handleApiResult because it handles delegated LLM calls rather than direct API calls. Using createErrorResponse for error messages is the correct approach for this tool.

Applied to files:

mcp-server/src/tools/get-operation-status.js
mcp-server/src/tools/parse-prd.js
mcp-server/src/tools/scope-down.js
mcp-server/src/tools/remove-dependency.js
mcp-server/src/tools/complexity-report.js
mcp-server/src/tools/update.js
mcp-server/src/tools/set-task-status.js
mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/fix-dependencies.js
mcp-server/src/tools/expand-task.js
mcp-server/src/tools/next-task.js
mcp-server/src/tools/add-tag.js
mcp-server/src/tools/models.js
mcp-server/src/tools/analyze.js
mcp-server/src/tools/expand-all.js
mcp-server/src/tools/initialize-project.js
mcp-server/src/tools/research.js
mcp-server/src/tools/use-tag.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Follow the provided structure for adding subtasks, including required options and detailed error handling.

Applied to files:

mcp-server/src/tools/add-task.js
mcp-server/src/tools/update-task.js
mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/add-subtask.js
mcp-server/src/tools/clear-subtasks.js
mcp-server/src/tools/move-task.js
mcp-server/src/tools/remove-subtask.js

📚 Learning: 2025-07-20T01:35:05.831Z

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: scripts/modules/task-manager/parse-prd.js:226-226
Timestamp: 2025-07-20T01:35:05.831Z
Learning: The parsePRD function in scripts/modules/task-manager/parse-prd.js has a different parameter structure than other task-manager functions - it uses `options` parameter instead of `context` parameter because it generates tasks from PRD documents rather than operating on existing tasks.

Applied to files:

mcp-server/src/tools/add-task.js
mcp-server/src/tools/scope-up.js
scripts/modules/commands.js
mcp-server/src/tools/update-task.js
mcp-server/src/tools/parse-prd.js
mcp-server/src/tools/delete-tag.js
mcp-server/src/tools/scope-down.js
mcp-server/src/tools/complexity-report.js
mcp-server/src/tools/update.js
mcp-server/src/tools/set-task-status.js
mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/add-subtask.js
mcp-server/src/tools/expand-task.js
mcp-server/src/tools/next-task.js
mcp-server/src/tools/models.js
mcp-server/src/tools/clear-subtasks.js
mcp-server/src/tools/move-task.js
mcp-server/src/tools/remove-subtask.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Remove references to non-existent tasks during validation

Applied to files:

mcp-server/src/tools/add-task.js
scripts/modules/commands.js
mcp-server/src/tools/update-task.js
apps/mcp/src/tools/tasks/get-tasks.tool.ts
mcp-server/src/tools/move-task.js
mcp-server/src/tools/remove-subtask.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-07-17T21:33:57.585Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1002
File: .changeset/puny-friends-give.md:2-3
Timestamp: 2025-07-17T21:33:57.585Z
Learning: In the eyaltoledano/claude-task-master repository, the MCP server code in mcp-server/src/ is part of the main "task-master-ai" package, not a separate "mcp-server" package. When creating changesets for MCP server changes, use "task-master-ai" as the package name.

Applied to files:

mcp-server/src/tools/add-task.js
mcp-server/src/tools/update-task.js
mcp-server/src/tools/remove-dependency.js
mcp-server/src/tools/set-task-status.js
mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/add-subtask.js
mcp-server/src/tools/expand-task.js
mcp-server/src/tools/next-task.js
mcp-server/src/tools/list-tags.js
mcp-server/src/tools/clear-subtasks.js
mcp-server/src/tools/move-task.js
mcp-server/src/tools/remove-subtask.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Use numeric IDs for direct task references

Applied to files:

mcp-server/src/tools/add-task.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Check for and remove references to non-existent tasks during cleanup

Applied to files:

mcp-server/src/tools/add-task.js
scripts/modules/commands.js
mcp-server/src/tools/update-task.js
apps/mcp/src/tools/tasks/get-tasks.tool.ts
mcp-server/src/tools/clear-subtasks.js
mcp-server/src/tools/remove-subtask.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Keep action handlers concise and focused; extract core functionality to appropriate modules and import/call relevant functions from core modules, passing parsed options.

Applied to files:

mcp-server/src/tools/scope-up.js
mcp-server/src/tools/update.js
mcp-server/src/tools/expand-all.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Applied to files:

scripts/modules/commands.js
mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Use path.join() to construct file paths, follow established naming conventions (like task_001.txt), check file existence before deletion, and handle file deletion errors gracefully.

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : For AI-powered commands that benefit from project context, use the ContextGatherer utility for multi-source context extraction, support task IDs, file paths, custom context, and project tree, implement fuzzy search for automatic task discovery, and display detailed token breakdown for transparency.

Applied to files:

scripts/modules/commands.js
mcp-server/src/tools/expand-task.js
mcp-server/src/tools/move-task.js

📚 Learning: 2025-09-26T19:10:32.906Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1252
File: tsconfig.json:22-28
Timestamp: 2025-09-26T19:10:32.906Z
Learning: In the eyaltoledano/claude-task-master repository, all internal tm/ package path mappings in tsconfig.json consistently point to TypeScript source files (e.g., "./packages/*/src/index.ts") rather than built JavaScript. This is intentional architecture because tsdown bundles internal packages directly from source during build time, eliminating the need for separate compilation of internal packages.

Applied to files:

scripts/modules/commands.js
apps/mcp/src/tools/tasks/get-tasks.tool.ts
mcp-server/src/tools/move-task.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Regenerate task files after destructive operations, passing all required parameters to generation functions, and provide an option to skip regeneration if needed.

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Do not create circular dependencies between subtasks

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Support both task and subtask dependencies in cycle detection

Applied to files:

scripts/modules/commands.js
mcp-server/src/tools/update-subtask.js

📚 Learning: 2025-07-18T05:38:17.352Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 943
File: scripts/modules/task-manager/move-task.js:24-24
Timestamp: 2025-07-18T05:38:17.352Z
Learning: In the Claude Task Master system, core task-manager functions are designed with fallback mechanisms for missing projectRoot parameters using the pattern `const projectRoot = providedProjectRoot || findProjectRoot();`. The readJSON and writeJSON functions have default parameters (projectRoot = null, tag = null) and handle missing parameters gracefully. Adding strict validation to these core functions would break the established flexible architecture pattern.

Applied to files:

scripts/modules/commands.js
mcp-server/src/tools/update-task.js
mcp-server/src/tools/copy-tag.js
mcp-server/src/tools/add-tag.js
mcp-server/src/tools/move-task.js

📚 Learning: 2025-07-18T17:10:02.683Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dev_workflow.mdc:0-0
Timestamp: 2025-07-18T17:10:02.683Z
Learning: Applies to .taskmaster/config.json : Store Taskmaster configuration settings (AI model selections, parameters, logging level, default subtasks/priority, project name, tag management) in `.taskmaster/config.json` in the project root. Do not configure these via environment variables.

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-31T21:48:00.389Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 997
File: apps/extension/src/services/task-repository.ts:25-57
Timestamp: 2025-07-31T21:48:00.389Z
Learning: In the eyaltoledano/claude-task-master repository, every task is always part of a tag - there is no concept of untagged tasks. The tag system is mandatory and comprehensive, meaning all tasks exist within a tag context (with 'master' as the default tag if none specified).

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Validate that referenced tasks exist before adding dependencies

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-18T07:52:44.890Z

Learnt from: mm-parthy
Repo: eyaltoledano/claude-task-master PR: 943
File: scripts/modules/ui.js:1211-1211
Timestamp: 2025-07-18T07:52:44.890Z
Learning: The boundary-first tag resolution pattern means that context validation in UI functions like displayTaskById is unnecessary because tag and projectRoot resolution happens at the CLI command boundary layer before reaching these functions.

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-09-17T19:08:57.882Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1211
File: tests/integration/cli/complex-cross-tag-scenarios.test.js:20-22
Timestamp: 2025-09-17T19:08:57.882Z
Learning: The user Crunchyman-ralph confirmed that in their build pipeline, they assume dist/ artifacts are already built by the time tests run, when tests reference dist/task-master.js instead of bin/task-master.js.

Applied to files:

scripts/modules/commands.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Represent task dependencies as arrays of task IDs

Applied to files:

scripts/modules/commands.js
apps/mcp/src/tools/tasks/get-tasks.tool.ts

📚 Learning: 2025-07-21T02:41:13.453Z

Learnt from: rtmcrc
Repo: eyaltoledano/claude-task-master PR: 933
File: scripts/modules/task-manager/expand-all-tasks.js:0-0
Timestamp: 2025-07-21T02:41:13.453Z
Learning: In scripts/modules/task-manager/expand-all-tasks.js, the success flag should always be true when the expansion process completes successfully, even if individual tasks fail due to LLM errors. Failed tasks are designed to be expanded on subsequent iterations, so individual task failures don't constitute overall operation failure.

Applied to files:

scripts/modules/commands.js
mcp-server/src/tools/expand-task.js
mcp-server/src/tools/expand-all.js

📚 Learning: 2025-10-01T19:53:34.261Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1262
File: scripts/modules/task-manager/update-tasks.js:216-233
Timestamp: 2025-10-01T19:53:34.261Z
Learning: For scripts/modules/task-manager/*.js: Use generateObjectService with Zod schemas for structured AI responses rather than generateTextService + manual JSON parsing, as modern AI providers increasingly support the tool use and generateObject paradigm with improved reliability.

Applied to files:

mcp-server/src/tools/update-task.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Use string IDs with dot notation (e.g., "1.2") for subtask references

Applied to files:

mcp-server/src/tools/update-task.js
mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/add-subtask.js
mcp-server/src/tools/remove-subtask.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Use kebab-case for long-form option names (e.g., --output-format), provide single-letter shortcuts when appropriate, and use consistent option names across similar commands.

Applied to files:

mcp-server/src/tools/scope-down.js
mcp-server/src/tools/update.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Provide feedback about the removal result

Applied to files:

mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Handle different ID formats consistently when removing dependencies

Applied to files:

mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Check for and remove self-references during cleanup

Applied to files:

mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Check if the dependency exists before removing

Applied to files:

mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Format dependency lists consistently for visualization

Applied to files:

mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Provide clear error messages for non-existent dependencies

Applied to files:

mcp-server/src/tools/remove-dependency.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Use kebab-case for command names (e.g., analyze-complexity) and descriptive, action-oriented names.

Applied to files:

mcp-server/src/tools/complexity-report.js

📚 Learning: 2025-07-18T17:09:40.548Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Allow numeric subtask IDs to reference other subtasks within the same parent

Applied to files:

mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/add-subtask.js
mcp-server/src/tools/remove-subtask.js

📚 Learning: 2025-07-18T17:08:48.695Z

Learnt from: CR
Repo: eyaltoledano/claude-task-master PR: 0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Follow the provided structure for removing subtasks, including required options, conversion option, and detailed error handling.

Applied to files:

mcp-server/src/tools/update-subtask.js
mcp-server/src/tools/add-subtask.js
mcp-server/src/tools/clear-subtasks.js
mcp-server/src/tools/remove-subtask.js
mcp-server/src/tools/remove-task.js

📚 Learning: 2025-09-26T19:05:47.555Z

Learnt from: Crunchyman-ralph
Repo: eyaltoledano/claude-task-master PR: 1252
File: packages/ai-sdk-provider-grok-cli/package.json:11-13
Timestamp: 2025-09-26T19:05:47.555Z
Learning: In the eyaltoledano/claude-task-master repository, internal tm/ packages use a specific export pattern where the "exports" field points to TypeScript source files (./src/index.ts) while "main" points to compiled output (./dist/index.js) and "types" points to source files (./src/index.ts). This pattern is used consistently across internal packages like tm/core and tm/ai-sdk-provider-grok-cli because they are consumed directly during build-time bundling with tsdown rather than being published as separate packages.

Applied to files:

apps/mcp/src/tools/tasks/get-tasks.tool.ts
mcp-server/src/tools/move-task.js

🧬 Code graph analysis (30)

mcp-server/src/tools/add-task.js (1)

mcp-server/src/tools/scope-up.js (1)

mcp-server/src/tools/update-task.js (1)

mcp-server/src/tools/parse-prd.js (1)

mcp-server/src/tools/delete-tag.js (1)

mcp-server/src/tools/scope-down.js (1)

mcp-server/src/tools/remove-dependency.js (2)

mcp-server/src/tools/complexity-report.js (2)

mcp-server/src/tools/update.js (1)

mcp-server/src/tools/set-task-status.js (1)

mcp-server/src/tools/update-subtask.js (1)

mcp-server/src/tools/copy-tag.js (1)

mcp-server/src/tools/add-subtask.js (1)

mcp-server/src/tools/fix-dependencies.js (1)

mcp-server/src/tools/expand-task.js (2)

apps/mcp/src/tools/tasks/get-tasks.tool.ts (2)

mcp-server/src/tools/next-task.js (1)

mcp-server/src/tools/add-tag.js (1)

mcp-server/src/tools/list-tags.js (1)

mcp-server/src/tools/models.js (2)

mcp-server/src/tools/analyze.js (1)

mcp-server/src/tools/rename-tag.js (1)

mcp-server/src/tools/expand-all.js (1)

mcp-server/src/tools/clear-subtasks.js (2)

mcp-server/src/tools/move-task.js (3)

mcp-server/src/tools/remove-subtask.js (2)

mcp-server/src/tools/initialize-project.js (1)

mcp-server/src/tools/research.js (1)

mcp-server/src/tools/remove-task.js (1)

mcp-server/src/tools/use-tag.js (1)

🪛 GitHub Actions: CI

scripts/modules/commands.js

[error] 2548-2552: Formatter would have reformatted code. Formatting issue detected by biome format (format-check) in commands.js.

mcp-server/src/tools/parse-prd.js

[error] 88-92: Formatter would have reformatted code. Formatting issue detected by biome format (format-check) in parse-prd.js.

🔇 Additional comments (33)

coderabbitai · 2025-11-21T11:19:57Z

 				const data = readJSON(
-					taskMaster.getTasksPath(),
+					tasksPath,
 					taskMaster.getProjectRoot(),
 					tag
 				);


⚠️ Potential issue | 🟡 Minor

Fix formatting issue flagged by pipeline.

The CI pipeline reports that biome format would reformat this code block. Run the formatter to resolve this.

#!/bin/bash # Run biome formatter to fix the formatting issue npx @biomejs/biome format --write scripts/modules/commands.js

🧰 Tools

🪛 GitHub Actions: CI

[error] 2548-2552: Formatter would have reformatted code. Formatting issue detected by biome format (format-check) in commands.js.

🤖 Prompt for AI Agents

In scripts/modules/commands.js around lines 2548 to 2552, the three-argument call to readJSON is misformatted and the CI expects Biome formatting; run the Biome formatter or reformat the block so arguments align per project style (for example place each argument on its own line with proper indentation) — the quickest fix is to run the project formatter: execute npx @biomejs/biome format --write scripts/modules/commands.js (or apply the same formatting changes manually) then re-run CI.

Crunchyman-ralph added 2 commits November 21, 2025 12:07

chore: fix coderabbit issues

b7369a0

chore: apply requested changes

98a23f3

coderabbitai Bot reviewed Nov 21, 2025

View reviewed changes

Crunchyman-ralph added 2 commits November 21, 2025 12:34

chore: fix CI

3f1619e

chore: more requested changes

4946c0f

Crunchyman-ralph merged commit 522d9af into next Nov 21, 2025
7 checks passed

Crunchyman-ralph deleted the ralph/chore/fix.coderabbit.issues branch November 21, 2025 11:40

coderabbitai Bot mentioned this pull request Dec 21, 2025

feat: Add tool annotations for improved LLM tool understanding #1543

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ralph/chore/fix.coderabbit.issues#1432

Ralph/chore/fix.coderabbit.issues#1432
Crunchyman-ralph merged 4 commits into
nextfrom
ralph/chore/fix.coderabbit.issues

Crunchyman-ralph commented Nov 21, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot Nov 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Crunchyman-ralph commented Nov 21, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

Description

Related Issues

How to Test This

Contributor Checklist

Changelog Entry

For Maintainers

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Crunchyman-ralph commented Nov 21, 2025 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Nov 21, 2025 •

edited

Loading

coderabbitai Bot commented Nov 21, 2025 •

edited

Loading