forked from mpaland/printf
-
Notifications
You must be signed in to change notification settings - Fork 63
C90 support #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
C90 support #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9edff8 to
5286002
Compare
Owner
|
I will not have time to properly look at this before mid-September. But - I'll already say that replacing |
1027bcb to
b4d4292
Compare
hoffbrinkle
reviewed
Sep 14, 2025
…an C++/C99-style single-line comments (`//`) by script Rest will be convert manually Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
…an C++/C99-style single-line comments (`//`) manually Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
b4d4292 to
3f56b9c
Compare
Author
|
@eyalroz ping for take a look |
eyalroz
requested changes
Sep 27, 2025
Owner
eyalroz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mosty ok, but please note my requested changes and questions.
c1e6b43 to
28f37bd
Compare
Fixes ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Fixes inline for C90 Enable Werror=declaration-after-statement for not breakage C90 in future Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
28f37bd to
107b4d9
Compare
Author
|
@eyalroz done, ping for review |
eyalroz
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script for comment convert is