feat: add imports, use decorator for exports #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 6, 2024 12:39
added 2 commits
September 11, 2024 20:10
Author
|
This is currently in a working state, but failing with wazero in compiler mode: wazero/wazero#2313 - waiting to see if there's a potential fix or if we should switch back to interpreter mode in the CLI before merging this. |
added 7 commits
September 12, 2024 17:40
bhelx
reviewed
Sep 16, 2024
| asset_name: extism-py-aarch64-macos-${{ github.event.release.tag_name }} | ||
| shasum_cmd: shasum -a 256 | ||
| target: aarch64-apple-darwin | ||
| # - name: windows |
Contributor
There was a problem hiding this comment.
did you have some issues with windows? not a blocker just curious
Author
There was a problem hiding this comment.
Yeah it was failing (maybe because of something about locating the python library?) but I want to try to figure out what's going on using an actual Windows machine instead of debugging on CI.
bhelx
reviewed
Sep 16, 2024
Comment on lines
4
to
15
| @extism.import_fn("example", "do_something") | ||
| def do_something(): | ||
| pass | ||
|
|
||
| @extism.import_fn("example", "reflect") | ||
| def reflect(x: str) -> str: | ||
| pass | ||
|
|
||
| @extism.plugin_fn | ||
| def count_vowels(): | ||
| input = reflect(extism.input_str()) | ||
| do_something() |
bhelx
approved these changes
Sep 16, 2024
Contributor
bhelx
left a comment
There was a problem hiding this comment.
Looks great! a few questions but no blockers
added 3 commits
September 17, 2024 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Closes #5
Closes #6
__all__to using theplugin_fndecorator