Skip to content

Conversation

@G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Jan 22, 2025

No description provided.

@G4Vi G4Vi requested review from bhelx and zshipko as code owners January 22, 2025 19:29
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Is there any tool we can run on CI to check that this is in sync with the source files?

@G4Vi
Copy link
Contributor Author

G4Vi commented Jan 22, 2025

Nice work! Is there any tool we can run on CI to check that this is in sync with the source files?

Potentially, stubtest could be used, however, it would require a custom wasm python build to use. The difficulty with both getting accessible definitions and testing it stems from the extism module being partially implemented in rust so the checks cannot be done statically, it must be ran in wasm.

@G4Vi G4Vi merged commit 09e4604 into main Jan 22, 2025
4 checks passed
@G4Vi G4Vi deleted the gavin/20250122-add-stub-file branch January 22, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants