Document extism.Json #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhelx
commented
Oct 23, 2024
|
|
||
| @dataclass | ||
| class User(extism.Json): | ||
| admin: bool |
Contributor
Author
There was a problem hiding this comment.
@zshipko does there exist a way to provide the keyname if it differs from the property name?
There was a problem hiding this comment.
I don't think so, we may have to add another decorator for that.
Contributor
Author
There was a problem hiding this comment.
no problem, just checking
|
The macos install script test has been flaky for some reason, I need to spend some time fixing CI for this repo |
b2dcee7 to
73ec6e4
Compare
zshipko
approved these changes
Oct 24, 2024
zshipko
left a comment
There was a problem hiding this comment.
Changes look good, I think if you rebase CI will pass. But since this doesn't touch the code we can probably just merge this as-is.
73ec6e4 to
746d3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this look correct @zshipko ? Is there maybe a test i can grab?