Add support for IBM Cloud Custom Credentials secret type#4838
Closed
yonatanyell wants to merge 5 commits intoexternal-secrets:mainfrom
Closed
Add support for IBM Cloud Custom Credentials secret type#4838yonatanyell wants to merge 5 commits intoexternal-secrets:mainfrom
yonatanyell wants to merge 5 commits intoexternal-secrets:mainfrom
Conversation
added 2 commits
May 26, 2025 13:47
Signed-off-by: Yonathan-Yellin <yonathan.yellin@ibm.com>
Collaborator
|
@knelasevero Remind me, this PR should have an image auto-built for it so we can verify it further right? |
Contributor
|
It should be somewhere in the log, yes. |
added 3 commits
May 26, 2025 15:17
Signed-off-by: Yonathan-Yellin <yonathan.yellin@ibm.com>
# Conflicts: # pkg/provider/ibm/provider_test.go
Signed-off-by: Yonathan-Yellin <yonathan.yellin@ibm.com>
|
Collaborator
|
Replaced by this PR #4899 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
IBM Cloud's Secret Manager service added a new secret type called Custom Credentials.
Related Issue
Feature request
Proposed Changes
We would like to add the support for this secret kind in ESO, for the use of IBM Cloud users who need to manage the life cycle of custom credentials within Secrets Manager, and want to use ESO to pull them into Kubernetes secrets
Checklist
git commit --signoffmake testmake reviewable