Skip to content

fix: remove the conversion hook completely#4675

Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom
Skarlso:fix-generate-remove-conversion
Apr 16, 2025
Merged

fix: remove the conversion hook completely#4675
Skarlso merged 3 commits intoexternal-secrets:mainfrom
Skarlso:fix-generate-remove-conversion

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Apr 16, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #4673

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@Skarlso Skarlso requested a review from a team as a code owner April 16, 2025 08:08
@Skarlso Skarlso requested a review from knelasevero April 16, 2025 08:08
@Skarlso Skarlso mentioned this pull request Apr 16, 2025
Merged
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Apr 16, 2025 

➜ kubectl apply -f deploy/crds/bundle.yaml
customresourcedefinition.apiextensions.k8s.io/clusterexternalsecrets.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/clusterpushsecrets.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/clustersecretstores.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/externalsecrets.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/pushsecrets.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/secretstores.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/acraccesstokens.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/clustergenerators.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/ecrauthorizationtokens.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/fakes.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/gcraccesstokens.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/generatorstates.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/githubaccesstokens.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/grafanas.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/passwords.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/quayaccesstokens.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/stssessiontokens.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/uuids.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/vaultdynamicsecrets.generators.external-secrets.io created
customresourcedefinition.apiextensions.k8s.io/webhooks.generators.external-secrets.io created

Should be okay now. 🤞

@Skarlso Skarlso requested a review from gusfcarvalho April 16, 2025 08:10
@Skarlso
fix: remove the conversion hook completely
36b7db7 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the fix-generate-remove-conversion branch from 3d83dff to 36b7db7 Compare April 16, 2025 08:28
@Syed-Shahidh-Ilhan
Copy link
Copy Markdown

Syed-Shahidh-Ilhan commented Apr 16, 2025 •
edited
Loading

thank you @Skarlso !

gusfcarvalho
gusfcarvalho reviewed Apr 16, 2025
View reviewed changes
gusfcarvalho
gusfcarvalho reviewed Apr 16, 2025
View reviewed changes
Skarlso and others added 2 commits April 16, 2025 11:22
@Skarlso @gusfcarvalho
Update hack/helm.generate.sh
22ce4bf 
Co-authored-by: Gustavo Fernandes de Carvalho <17139678+gusfcarvalho@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
removed the second mv
d3156ec 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Skarlso Skarlso merged commit 8d037d1 into external-secrets:main Apr 16, 2025
22 checks passed
@kevindurb kevindurb mentioned this pull request Jul 31, 2025
Open
1 task
@parsec-renovate parsec-renovate bot mentioned this pull request Jul 31, 2025
Open
1 task
@robo-ross robo-ross bot mentioned this pull request Jul 30, 2025
Open
1 task
@monova-bot monova-bot bot mentioned this pull request Jul 30, 2025
Open
1 task
@renovate-f882d renovate-f882d bot mentioned this pull request Jul 31, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 21, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gusfcarvalho gusfcarvalho gusfcarvalho approved these changes

@knelasevero knelasevero Awaiting requested review from knelasevero knelasevero was automatically assigned from external-secrets/maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Skarlso @Syed-Shahidh-Ilhan @gusfcarvalho