adds Helm value option to disable OpenShift finalizers in RBAC#4570
Closed
bb-Ricardo wants to merge 1 commit intoexternal-secrets:mainfrom
Closed
adds Helm value option to disable OpenShift finalizers in RBAC#4570bb-Ricardo wants to merge 1 commit intoexternal-secrets:mainfrom
bb-Ricardo wants to merge 1 commit intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
|
5 tasks
Member
|
This PR is superseded by #4572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Vanilla kubernetes has no API endpoints for
finalizers. This causes issues in our scoped RBAC deployment.Related Issue
Fixes #...
Proposed Changes
This PR adds an option to disable the finalisers from being included in Role/ClusterRole
Checklist
git commit --signoffmake testmake reviewable