Skip to content

feat(parameterstore): add support to set parameter tier for pushsecrets#3581

Closed
vsantos wants to merge 2 commits intoexternal-secrets:mainfrom
vsantos:feat/parametertier_pushsecrets_3422
Closed

feat(parameterstore): add support to set parameter tier for pushsecrets#3581
vsantos wants to merge 2 commits intoexternal-secrets:mainfrom
vsantos:feat/parametertier_pushsecrets_3422

Conversation

@vsantos
Copy link
Copy Markdown
Contributor

@vsantos vsantos commented Jun 14, 2024

Problem Statement

Currently, we don't have the option to set which parameter tier to use for the AWS parameter store, and as a result, all secrets are stored using the default tier Standard. This PR adds the possibility to work with parameter tier Advanced and all its policies.

Related Issue

Fixes #3422

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@vsantos vsantos requested a review from a team as a code owner June 14, 2024 02:03
@vsantos vsantos requested a review from Skarlso June 14, 2024 02:03
@vsantos
Copy link
Copy Markdown
Contributor Author

vsantos commented Jun 14, 2024

/ok-to-test sha=654c946e

@vsantos vsantos changed the title feat(parameterstore): add support to set parameter tier for pushsecrets draft: feat(parameterstore): add support to set parameter tier for pushsecrets Jun 17, 2024
@vsantos vsantos changed the title draft: feat(parameterstore): add support to set parameter tier for pushsecrets feat(parameterstore): add support to set parameter tier for pushsecrets Jun 17, 2024
@vsantos vsantos marked this pull request as draft June 17, 2024 03:01
@vsantos vsantos force-pushed the feat/parametertier_pushsecrets_3422 branch 2 times, most recently from 6609c5e to 6728032 Compare June 17, 2024 03:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Jun 19, 2024
Merged
Merged
@Skarlso Skarlso self-assigned this Jul 25, 2024
@vsantos vsantos force-pushed the feat/parametertier_pushsecrets_3422 branch from b431bf5 to 396bd7b Compare August 6, 2024 02:19
@vsantos
feat(parameterstore): add support to set parameter tier for pushsecrets
057f380 
Signed-off-by: Victor Santos <vsantos.py@gmail.com>

commit 45cf113
Merge: 624d7c8 21f1dca
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Wed Sep 4 03:45:03 2024 -0300

    merge main and inherit withDecryption for SecureString

commit 624d7c8
Merge: 396bd7b d230fd7
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Sun Aug 11 14:46:10 2024 -0300

    Merge branch 'main' into feat/parametertier_pushsecrets_3422

commit 396bd7b
Merge: 6007858 7343875
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Mon Aug 5 23:05:46 2024 -0300

    merge main

    Signed-off-by: Victor Santos <vsantos.py@gmail.com>

commit 6007858
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Mon Jun 17 00:51:39 2024 -0300

    simplify withDecryption

commit 6728032
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Mon Jun 17 00:00:01 2024 -0300

    replace refactor words

commit 16a1742
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Sun Jun 16 23:51:14 2024 -0300

    fix yaml structure

commit b0f01d0
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Sun Jun 16 23:39:19 2024 -0300

    fix comparison in case of secrets

commit e5fa988
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Sun Jun 16 22:54:00 2024 -0300

    refactor parameterstore metadata

commit 56fc233
Merge: 32fdc0b 8addd67
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Sun Jun 16 22:37:00 2024 -0300

    Merge branch 'feat/parametertier_pushsecrets_3422' of github.com:vsantos/external-secrets into feat/parametertier_pushsecrets_3422

commit 32fdc0b
Merge: 654c946 199c910
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Sun Jun 16 22:36:44 2024 -0300

    fix merge

commit 8addd67
Merge: 654c946 e01fc82
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Thu Jun 13 23:03:45 2024 -0300

    Merge branch 'main' into feat/parametertier_pushsecrets_3422

commit 654c946
Author: Victor Santos <vsantos.py@gmail.com>
Date:   Thu Jun 13 22:47:30 2024 -0300

    feat(parameterstore): add support to set parameter tier for pushsecrets

    Signed-off-by: Victor Santos <vsantos.py@gmail.com>
@vsantos vsantos force-pushed the feat/parametertier_pushsecrets_3422 branch from 45cf113 to 057f380 Compare September 4, 2024 06:52
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Sep 4, 2024

@vsantos Please also sign all your commits. :)

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Sep 4, 2024

I see, this would be a breaking change. And as such, would likely be only released with either a feature flag, or a minor version update.

@vsantos
Copy link
Copy Markdown
Contributor Author

vsantos commented Sep 5, 2024

Hi @Skarlso, indeed! Thanks for keeping an eye on it. I still have a lot to refactor according to @moolen's suggestions. My last action will be a git squash. 🙌

My plan is to ensure the old "metadata" still works but with a deprecation announcement. While the documentation suggests the usage of the "refactored feature" instead. It will add some noise to the code but I won't break anyone.

Any thoughts or tips?

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Sep 5, 2024

Tips regarding how to make it deprecated or being backwards compatible? :)

The former, just add a notice in the logs, there isn't too much else to do.

The latter, since you are json unmarshalling anyways, try the first structure first, than the second one I guess.

@ameetmali
Copy link
Copy Markdown

ameetmali commented Oct 15, 2024

Hi @Skarlso, indeed! Thanks for keeping an eye on it. I still have a lot to refactor according to @moolen's suggestions. My last action will be a git squash. 🙌

My plan is to ensure the old "metadata" still works but with a deprecation announcement. While the documentation suggests the usage of the "refactored feature" instead. It will add some noise to the code but I won't break anyone.

Any thoughts or tips?

@vsantos We are looking for the same update you are working on in this draft PR. Please let me know if I can help in anyway submitting this PR. Thanks!

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Dec 31, 2024

I'm going to implement this using the latest Metadata format. It will be a breaking change, but that's fine, because our next release will be a minor one to 0.13.0.

I hope you don't mind be superseding this @vsantos. :)

@Skarlso Skarlso closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Awaiting requested review from Skarlso Skarlso was automatically assigned from external-secrets/maintainers

Assignees

@Skarlso Skarlso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add SecureString for PushString to AWS Parameter Store

3 participants

@vsantos @Skarlso @ameetmali