Helm externalObjects#3417
Closed
Gianluca755 wants to merge 2 commits intoexternal-secrets:mainfrom
Gianluca755:main
Closed
Helm externalObjects#3417Gianluca755 wants to merge 2 commits intoexternal-secrets:mainfrom Gianluca755:main
Gianluca755 wants to merge 2 commits intoexternal-secrets:mainfrom
Gianluca755:main
Conversation
Signed-off-by: Gianluca755 <19376177+Gianluca755@users.noreply.github.com>
Member
|
hi @Gianluca755 ! Can you add some unit test definitions, and then make sure to run |
Member
|
This unit test can be as simple as adding a |
|
5 tasks
Member
|
thanks @Gianluca755 for your contribution! This was picked up in #3421 following a similar logic you added. Thank you so much!! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding the extraObject field in the Helm chart such that additional resources can be injected in the Helm chart from the values.yaml file.
Checklist
git commit --signoffmake testmake reviewable