Closed
Conversation
Contributor
There was a problem hiding this comment.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt: Formats the codemake check-diff: Ensures the branch is cleanmake reviewable: Ensures a PR is ready for review
|
Kudos, SonarCloud Quality Gate passed!
|
|
Any work being done on this, or is it stale? We would LOVE a provider for github repository-secrets as we could omit all our custom scripts lifting this from github secrets, to azure keyvault today. |
Contributor
|
Closing since the PR seems to be abandoned, and we also have #3115 |
5 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
I'm implementing the github secret store provider
Related Issue
Implements part of #1727
Proposed Changes
How do you like to solve the issue and why?
I have implemented the start of the github provider for external secrets based on github actions organisations secrets.
Checklist
git commit --signoffmake testmake reviewable