feat: DeletionPolicy support for webhook provider (external-secrets#1…#2066
Merged
moolen merged 4 commits intoexternal-secrets:mainfrom Feb 27, 2023
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt: Formats the codemake check-diff: Ensures the branch is cleanmake reviewable: Ensures a PR is ready for review
moolen
reviewed
Feb 27, 2023
Member
moolen
left a comment
There was a problem hiding this comment.
Looks good, could you please add a note to the provider docs that a 404 may cause secret deletion? 🙏
Signed-off-by: ArtificialQualia <kendall.masse@gmail.com>
…com/libertymutual/external-secrets into 1958-webhook-deletionpolicy-support
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
This has now been added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
As identified in #1958 the webhook provider needs to be updated to return the correct error so that it may properly support the Merge/Delete DeletionPolicy.
Related Issue
Fixes #1958
Proposed Changes
This PR updates the webhook provider to return the appropriate error type on receiving a 404 from a webhook so that the DeletionPolicy logic will trigger correctly.
Checklist
git commit --signoffmake testmake reviewable