Update appVersion to newer build that resolves base image vulnerabilities#1744
Update appVersion to newer build that resolves base image vulnerabilities#1744accursoft wants to merge 1 commit intoexternal-secrets:mainfrom
Conversation
Update appVersion to newer build that resolves base image vulnerabilities. Signed-off-by: Gideon Sireling <gideons@il.ibm.com>
There was a problem hiding this comment.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt: Formats the codemake check-diff: Ensures the branch is cleanmake reviewable: Ensures a PR is ready for review
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -3,7 +3,7 @@ name: external-secrets | |||
| description: External secret management for Kubernetes | |||
| type: application | |||
| version: "0.6.1" | |||
There was a problem hiding this comment.
We would need to update the version field in order to update the helm chart; the chart-releaser action does not force-update: helm/chart-releaser-action#8
We could bump the version and let version and appVersion diverge. We can not use metadata 0.6.1+foobar or pre-release tags 0.6.1-foobar either as they do not take precedence over the existing release.
I feel that this should be an exception that we re-release an existing commit (and ask the user to set the image through helm values). We are not yet at the point where we want (and can) provide long-term support for major releases.
IMO the current state of main (which includes a rather large set of changes) should be released with a series of release candidates to further stabilize the feature(s) if necessary.
I'm a little hesitant to let the versions diverge. Could you live with setting the helm values for this time until we make a proper release?
My 2 cents, any other opinions? @external-secrets/maintainers
|
This is no longer needed. |
Update appVersion to newer build that resolves base image vulnerabilities.