Skip to content

cert-controller feature flag --enable-leader-election not in helm chart #5737

@jkleinlercher

Description

@jkleinlercher

Describe the bug
According to https://external-secrets.io/main/api/controller-options/ the cert-controller has a feature flag --enable-leader-election which should get enabled if you have multiple cert-controller replicas (same as the core-controller).

However, in the helm template for the cert-controller https://github.com/external-secrets/external-secrets/blob/main/deploy/charts/external-secrets/templates/cert-controller-deployment.yaml there is not attribute to enable this feature flag.

For the core-controller there is the

{{- if .Values.leaderElect }}
- --enable-leader-election=true
{{- end }}

To Reproduce
Steps to reproduce the behavior:

  1. provide all relevant manifests
  2. provide the Kubernetes and ESO version

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions