-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PushSecret panics on existing resource policy comparison (AWS SecretsManager) #5620
Copy link
Copy link
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Describe the bug
When creating a PushSecret with a defined resourcePolicy against a pre-existing secret with an existing resource policy, the operator panics on the reconciliation due to malformed policy comparison.
To Reproduce
Steps to reproduce the behavior:
- Create a secret in AWS secrets manager with a resource policy defined.
- Use the following manifests and apply then
- Operator version v1.0.0
Expected behavior
Expected to reconcile the existing secret and metadata against the provided manifest.
Additional context
I have a fix in the works locally, that relies on comparing the parsed maps by doing canonical comparison. If you are open to it, I can open a PR with the proposed fix and we could take it up from there.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Type
Projects
Status
Done
