-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
GCP PushSecret - Look for latest enabled secret version and reduce extraneous GetSecret call #5609
Copy link
Copy link
Open
Labels
area/gcpIssues / Pull Requests related to gcp providerIssues / Pull Requests related to gcp providerkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.triage/needs-informationIndicates an issue needs more information in order to work on it.Indicates an issue needs more information in order to work on it.
Description
Is your feature request related to a problem? Please describe.
This issue is related to a recent change that addressed this issue: #5584. The PR: #5593 does address the issue but does not cover the case where the latest secret version returned by GCP secret manager could be disabled.
Describe the solution you'd like
The SecretExists function returns if the latest enabled secret version of the supplied secret name exists.
Describe alternatives you've considered
We could leave the code as is, but it would be more efficient to remove the GetSecret call. Also, although the failure mode would be quite rare, it still exists.
Additional context
Add any other context or screenshots about the feature request here.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/gcpIssues / Pull Requests related to gcp providerIssues / Pull Requests related to gcp providerkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.triage/needs-informationIndicates an issue needs more information in order to work on it.Indicates an issue needs more information in order to work on it.
Type
Projects
Status
No status